Re: [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example

[Stephen Warren]

On 08/15/2014 10:08 AM, Nick Dyer wrote:
> On 15/08/14 13:01, Javier Martinez Canillas wrote:
> > > By passing all these keycodes the touchpad worked as expected for me and the
> > > driver did the same than the Chrome OS driver that has these keycodes hardcoded
> > > when is_tp is true.
> > >
> > > > at the protocol guide for T19.
> > >
> > > I don't have access to proper documentation and I wouldn't expect people to have
> > > access to non-public docs in order to use a Device Tree binding.
> > >
> > > That's why I wanted to document an example, so using this property could be
> > > easier for others and they shouldn't have to look at the driver in order to
> > > figure it out (and getting it wrong as you said :) )
> > >
> > > So it would be great if you could provide an example on how this is supposed to
> > > be used.
> >
> > Any comments on this? I would really appreciate if you can expand on how
> > this DT property is supposed to be used so I can re-spin the atmel support
> > patch for Peach boards.
>
> The below patch improves the documentation for the gpio-property.

That patch makes sense, and is a nice description,
Acked-by: Stephen Warren <swarren@xxxxxxxxxx>

> diff --git a/Documentation/devicetree/bindings/input/atmel,maxtouch.txt

>   Example:
>
>          touch@4b {

Perhaps it makes sense to add a linux,gpio-keymap property into the 
example too though; IIRC there was an earlier patch to the docs that did 
this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/