Re: [PATCH 7/7] aio: use iovec array rather than the single one

From: Benjamin LaHaise
Date: Fri Aug 15 2014 - 21:46:50 EST


On Fri, Aug 15, 2014 at 06:35:25PM -0600, Linus Torvalds wrote:
> Ben,
>
> *please* stop doing this kind of crap.
>
> You're creating fake emails with invalid senders. That's simply not acceptable.
...

I'll admit this was my mistake and I should have caught it while reviewing
the emails. At least in the past my mail client has generated the correct
From: headers, but I made a mistake somewhere in the process today. Evidently
passing in the --from= parameter to git-format-patch has been missing from
my scripts forever.

That said: git should *not* default to generating fake From: headers in
generated emails! Having the git default being completely unreasonable in
this case makes absolutely no sense to me, especially when git already
knows what my bloody email address is! It's wrong, it's clear that it's
wrong, so why is the default that way?

Damned rope shooting my foot off. Please excuse me while I go find a medic
to stop the bleeding...

-ben
--
"Thought is the essence of where you are now."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/