Re: [PATCH v4 6/8] power: max17040: Add ID for MAX77836 Fuel Gauge block

[Lee Jones]

On Wed, 27 Aug 2014, Krzysztof Kozlowski wrote:

> MAX77836 has the same Fuel Gauge as MAX17040/17048. The max17040 driver
> can be safely re-used. The patch adds MAX77836 ID to array of
> i2c_device_id.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
>  drivers/power/max17040_battery.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/max17040_battery.c b/drivers/power/max17040_battery.c
> index 0fbac861080d..165ffe381803 100644
> --- a/drivers/power/max17040_battery.c
> +++ b/drivers/power/max17040_battery.c
> @@ -278,6 +278,7 @@ static SIMPLE_DEV_PM_OPS(max17040_pm_ops, max17040_suspend, max17040_resume);
>  
>  static const struct i2c_device_id max17040_id[] = {
>  	{ "max17040", 0 },
> +	{ "max77836-battery", 0 },

Are you sure you want the IDs to be the same?

If they are not used, just drop them entirely.

>  	{ }
>  };
>  MODULE_DEVICE_TABLE(i2c, max17040_id);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/