Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree"

[Sergei Shtylyov]

On 12/01/2014 06:00 PM, SF Markus Elfring wrote:

> > > diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c
> > > index 911b216..7e44212 100644
> > > --- a/drivers/net/ppp/ppp_mppe.c
> > > +++ b/drivers/net/ppp/ppp_mppe.c
> > > @@ -238,8 +238,7 @@ static void *mppe_alloc(unsigned char *options, int optlen)
> > >        return (void *)state;
> > >
> > >        out_free:
> > > -        if (state->sha1_digest)
> > > -        kfree(state->sha1_digest);
> > > +    kfree(state->sha1_digest);

> >     Please keep this line aligned to the others.

> Can it be that the previous source code contained unwanted space
> characters at this place?

   Yes, it seems so.

> Do you want indentation fixes as a separate update step?

   Yes, that would be better to keep it separate.

> Regards,
> Markus

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/