Re: [PATCH 2/3] serial: 8250_omap: check how many bytes were injected
From: Sekhar Nori
Date: Wed Aug 26 2015 - 09:01:36 EST
On Wednesday 26 August 2015 06:14 PM, Peter Hurley wrote:
> On 08/14/2015 12:01 PM, Sebastian Andrzej Siewior wrote:
>> The function tty_insert_flip_string() returns an int and as such it
>> might fail. So the result is that I kindly asked to insert 48 bytes and
>> the function only insterted 32.
>> I have no idea what to do with the remaining 16 so I think dropping them
>> is the only option. I also increase the buf_overrun counter so userpace
>> has a clue that we lost bytes.
>
> No objection to the patch but I'm curious whether this is something you've
> actually observed and under what circumstances.
This was observed while doing a UART internal loopback test at 3Mbaud on
TI's DRA7 EVM.
Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/