RE: [v2] net: phy: fixed: propagate fixed link values to struct

[Madalin-Cristian Bucur]

> -----Original Message-----
> From: Stas Sergeev [mailto:stsp@xxxxxxx]
> Sent: Wednesday, August 26, 2015 6:51 PM
> To: Bucur Madalin-Cristian-B32716 <madalin.bucur@xxxxxxxxxxxxx>;
> f.fainelli@xxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Liberman Igal-
> B31950 <Igal.Liberman@xxxxxxxxxxxxx>
> Subject: Re: [v2] net: phy: fixed: propagate fixed link values to struct
> 
> 26.08.2015 17:58, Madalin Bucur ÐÐÑÐÑ:
> > The fixed link values parsed from the device tree are stored in
> > the struct fixed_phy member status. The struct phy_device members
> > speed, duplex were not updated.
> 
> ACK, but IMHO it will make more sense if you include that
> into your upcoming patch set rather than sending separately,
> as otherwise there is simply no in-kernel users of that new
> functionality (all the current users likely do not access
> these fields as early as you want to, so they don't care).
> In any case, the patch looks good to me and the policy is
> up to others.

Given that it's more of a fix than a feature, I think it can be picked up separate
from a certain driver that accesses those fields early but I guess Florian, David
will decide this.

Thanks,
Madalin