Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

From: BjÃrn Mork
Date: Mon Aug 31 2015 - 03:33:22 EST


Eugene Shatokhin <eugene.shatokhin@xxxxxxxxxx> writes:
> 28.08.2015 11:55, BjÃrn Mork ÐÐÑÐÑ:
>
>> I guess you are right. At least I cannot prove that you are not :)
>>
>> There is a bit too much complexity involved here for me...
>
> :-)
>
> Yes, it is quite complex.
>
> I admit, it was easier for me to find the races in usbnet (the tools
> like KernelStrider and RaceHound do the dirty work) than to analyze
> their consequences. The latter often requires some time and effort,
> and so it did this time.
>
> Well, any objections to this patch?

No objections from me.

But I would have liked it much better if the code became simpler instead
of more complex.


BjÃrn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/