Re: [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support

[Maxime Coquelin]

Hi Paul,

On 07/09/2015 10:17 AM, Paul Bolle wrote:
> > >+static int __exit st_fdma_remove(struct platform_device *pdev)
> > >+{
> > >+	struct st_fdma_dev *fdev = platform_get_drvdata(pdev);
> > >+
> > >+	wait_for_completion(&fdev->fw_ack);
> > >+
> > >+	st_fdma_clk_disable(fdev);
> > >+
> > >+	return 0;
> > >+}
> Since this driver is built-in only this means st_fdma_remove() can never
> be used, right?

It's not because a driver is built-in only that it does not need a 
remove callback.
An instance can be probed/removed any time via driver's bind/unbind 
SysFS entries.
Am I missing something?

Kind regards,
Maxime
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/