Re: [PATCH 13/15] perf script: Display data_src values
From: Jiri Olsa
Date: Wed Feb 24 2016 - 14:18:18 EST
On Wed, Feb 24, 2016 at 10:34:28AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Feb 24, 2016 at 09:46:54AM +0100, Jiri Olsa escreveu:
> > Adding support to display data_src values,
> > for events with data_src data in sample.
>
> While testing patches in this series I noticed this:
>
> [root@jouet ~]# perf mem record -a
> Error: unknown switch `a'
>
> Usage: perf mem record [<options>] [<command>]
> or: perf mem record [<options>] -- <command> [<options>]
>
> -e, --event <event> event selector. use 'perf mem record -e list' to list available events
> -v, --verbose be more verbose (show counter open errors, etc)
>
> [root@jouet ~]# perf mem record -- -a
> ^C[ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 3.149 MB perf.data (173 samples) ]
>
> [root@jouet ~]#
>
>
>
> Can't we imply the -- after 'record', i.e pass everything after 'record'
> to the underlying 'perf record' call?
I'll check on that, and try to have it in next version
jirka