Re: [PATCH 2/5] x86/mbm: Intel Memory B/W Monitoring enumeration and init

[Thomas Gleixner]

On Wed, 24 Feb 2016, Vikas Shivappa wrote:
> On Wed, 24 Feb 2016, Thomas Gleixner wrote:
> > You really should register the notifier _AFTER_ registering the pmu. That
> > needs to be fixed anyway, because the existing code leaks the notifier AND
> > memory in case perf_pmu_register fails.
> 
> Correct, Will fix the notifier leak

It's not only a notifier leak. The existing code also leaks memory. Please fix
that before adding the new stuff in a seperate patch.

Thanks,

	tglx