Re: perf/x86: Use kmalloc_array() in merge_attr()
From: SF Markus Elfring
Date: Wed Sep 14 2016 - 12:43:22 EST
>> * A multiplication for the size determination of a memory allocation
>> indicated that an array data structure should be processed.
>> Thus use the corresponding function "kmalloc_array".
>>
>> This issue was detected by using the Coccinelle software.
>>
>> * Replace the specification of a data structure by a pointer dereference
>> to make the corresponding size determination a bit safer according to
>> the Linux coding style convention.
>
> Why!?
How do you think about an information like the following from
the well-known script "checkpatch.pl"?
WARNING: Prefer kmalloc_array over kmalloc with multiply
Would you like to suggest any more constraints for this kind of
software refactoring?
Regards,
Markus