Re: [PATCH 14/26] drm/omap: dispc: Simplify _dispc_mgr_set_lcd_timings() parameters

[Tomi Valkeinen]

On 01/09/16 14:23, Peter Ujfalusi wrote:
> Instead of passing the omap_video_timings structure's members individually,
> use the pointer to the struct.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> ---
>  drivers/gpu/drm/omapdrm/dss/dispc.c | 38 ++++++++++++++-----------------------
>  1 file changed, 14 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
> index 858d87dd7fe8..915609be7a33 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
> @@ -3141,29 +3141,23 @@ bool dispc_mgr_timings_ok(enum omap_channel channel,
>  	return true;
>  }
>  
> -static void _dispc_mgr_set_lcd_timings(enum omap_channel channel, int hsync_len,
> -		int hfp, int hbp, int vsw, int vfp, int vbp,
> -		enum omap_dss_signal_level vsync_level,
> -		enum omap_dss_signal_level hsync_level,
> -		enum omap_dss_signal_edge data_pclk_edge,
> -		enum omap_dss_signal_level de_level,
> -		enum omap_dss_signal_edge sync_pclk_edge)
> -
> +static void _dispc_mgr_set_lcd_timings(enum omap_channel channel,
> +				       struct omap_video_timings *ovt)

const pointer?

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature