Re: [PATCH 0/3] LEGO MINDSTORMS I2C support

[Wolfram Sang]

On Mon, Sep 05, 2016 at 03:40:11PM -0500, David Lechner wrote:
> I'm working on getting LEGO MINDSTORMS[1] support in the Linux kernel.
> 
> They have a system of modular sensors that are hot-plugable, some of which use
> I2C communications. Unfortunately, these don't necessary follow standard I2C
> conventions, but they do have a well-defined register layout, so they are
> easy to detect.
> 
> This set of patches addresses the hot-plugability of the sensors.
> 
> [1]: http://mindstorms.lego.com

Thanks!

For a review, I'd need users of this functionality. In this case, a
master driver and probably a sensor driver. Can any regular I2C master
talk to these devices if they support talking to addresses 0x00-0x7f? My
first impression is that using a class is not the proper approach
because classes were used to limit access to devices, not to extend.
However, I'd need to see more code to check if that holds true.

Thanks,

   Wolfram

Attachment: signature.asc
Description: PGP signature