Re: [PATCH net-next 03/15] ethernet/intel: use core min/max MTU checking

From: Jakub Kicinski
Date: Mon Oct 17 2016 - 16:21:08 EST


Looks better, unfortunately, I can't test since net-next also seem to
make nfs implode on my setup.

On Mon, 17 Oct 2016 15:54:05 -0400, Jarod Wilson wrote:
> @@ -7187,6 +7180,11 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> netdev->vlan_features |= NETIF_F_HIGHDMA;
> }
>
> + /* MTU range: 68 - max_hw_frame_size */
> + netdev->min_mtu = ETH_MIN_MTU;

Nitpick: we probably don't have to reinit min_mtu if it's 68.