Re: drivers/pci/hotplug/ibmphp_ebda.c:409:1: warning: the frame size of 1108 bytes is larger than 1024 bytes

From: Kees Cook
Date: Tue Oct 18 2016 - 16:57:45 EST


On Mon, Oct 17, 2016 at 2:37 PM, Emese Revfy <re.emese@xxxxxxxxx> wrote:
> On Sun, 16 Oct 2016 06:52:16 +0800
> kbuild test robot <fengguang.wu@xxxxxxxxx> wrote:
>
>> drivers/pci/hotplug/ibmphp_ebda.c: In function 'ibmphp_access_ebda':
>> >> drivers/pci/hotplug/ibmphp_ebda.c:409:1: warning: the frame size of 1108 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>
> Hi,
>
> Thanks for the report. The problem is that these are large functions
> (there are a lot of basic blocks) and the entropy plugin instruments all basic blocks.
> I think the solution is to skip these functions which contain more than n basic blocks.
> Sorry, I haven't time to fix this bug. PaX Team will fix it in PaX.

This is controlled by CONFIG_FRAME_WARN. I don't think this is a
particular problem or should be avoided, but perhaps we can set the
default to 2048 (as done on 64BIT) if we're building with the entropy
plugin.

-Kees

--
Kees Cook
Nexus Security