Re: [PATCH] dmaengine: st_fdma: fix uninitialized variable access

From: Peter Griffin
Date: Wed Oct 19 2016 - 10:32:42 EST

Hi Arnd,

On Wed, 19 Oct 2016, Arnd Bergmann wrote:

> The newly added st_fdma driver introduces a build warning for
> allmodconfig when we add '-Wmaybe-uninitialized':
> drivers/dma/st_fdma.c: In function 'st_fdma_probe':
> drivers/dma/st_fdma.c:777:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> The warning is correct, though this can't happen in practice
> as the check is redundant (we don't get to this function if
> the pointer is NULL). Even if the function were called with a
> NULL of_node, the check is not needed because of_property_read_u32
> can deal with a NULL argument by returning an error.
> Removing the unnecessary code simplifies the function and avoids
> the condition that we get the warning for.
> Fixes: 6b4cd727eaf1 ("dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---

Acked-by: Peter Griffin <peter.griffin@xxxxxxxxxx>