Re: [RESEND PATCH v2 1/4] usb: dbc: early driver for xhci debug capability

[Lu Baolu]

Hi Peter,

On 10/20/2016 05:08 PM, Peter Zijlstra wrote:
> On Thu, Oct 20, 2016 at 10:41:32AM +0200, Peter Zijlstra wrote:
>> I'm already only using early_printk() because regular printk() is an
>> unfixable piece of crap, and now you're making early_printk() useless
>> too.
> Note that the existing USB debug port stuff doesn't seem to have a
> single lock in. Its just polling on readl and doing writel without any
> serialization what so ever.
>
> Not that I've ever actually used it (lack of the magic cable), but it at
> least looks like it should mostly work.
>

Thank you again.

Your comments make sense to me. I will remove the lock and work
queue usages in the new version.

Best regards,
Lu Baolu