Re: [PATCH 3/3] spi: sun6i: Use the driver data to get the buffer size

From: Milo Kim
Date: Fri Oct 21 2016 - 09:40:02 EST


On 10/21/2016 12:56 AM, Maxime Ripard wrote:
-static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi, int len)
> +static inline void sun6i_spi_drain_fifo(struct sun6i_spi *sspi)
> {
> + int len = sspi->fifo_depth;
> u32 reg, cnt;
> u8 byte;
I'm not so sure about this one. This function was initially to drain
any given number of bytes, which might be of interest at some point.

Removing that argument also remove that ability... Any particular
reason you want to change it?

I just wanted to remove duplicate variable but I agree with you. Let me drop this in the next patch-set. Thanks for your comments.

Best regards,
Milo