RE: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer

From: Leo Li
Date: Fri Oct 21 2016 - 12:19:25 EST




> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas@xxxxxxxxxx]
> Sent: Friday, October 21, 2016 10:37 AM
> To: Leo Li <leoyang.li@xxxxxxx>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; Minghuan Lian
> <minghuan.Lian@xxxxxxxxxxxxx>; Mingkai Hu <mingkai.hu@xxxxxxxxxxxxx>;
> Roy Zang <tie-fei.zang@xxxxxxxxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Stuart Yoder
> <stuart.yoder@xxxxxxx>
> Subject: Re: [PATCH] PCI: layerscape: Fix kernel panic on accessing NULL pointer
>
> On Mon, Oct 17, 2016 at 04:44:06PM -0500, Li Yang wrote:
> > Commit fefe6733e added reference to the pcie->drvdata before it is
> > initialized which causes a kernel panic. Fix the problem by
> > initializing the pcie->drvdata earlier before it is used.
> >
> > Reported-by: Stuart Yoder <stuart.yoder@xxxxxxx>
> > Signed-off-by: Li Yang <leoyang.li@xxxxxxx>
>
> I applied Marc Zyngier's identical patch to for-linus for v4.9. I don't know which
> was posted first, but I saw Marc's first. Sorry I didn't at least credit you when I
> applied it.

It's ok. Seems Marc sent the patch earlier and I didn't notice his patch. There is no difference as long as the problem is addressed. :)

Regards,
Leo