Re: [PATCH v2 4/4] cpufreq: pxa: convert to clock API
From: Robert Jarzmik
Date: Sat Oct 22 2016 - 17:37:42 EST
Viresh Kumar <viresh.kumar@xxxxxxxxxx> writes:
> On 15-10-16, 21:57, Robert Jarzmik wrote:
>> As the clock settings have been introduced into the clock pxa drivers,
>> which are now available to change the CPU clock by themselves, remove
>> the clock handling from this driver, and rely on pxa clock drivers.
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>
>> Since v1: added !OF Kconfig dependency
>> drivers/cpufreq/Kconfig.arm | 2 +-
>> drivers/cpufreq/pxa2xx-cpufreq.c | 191 ++++++++-------------------------------
>> 2 files changed, 40 insertions(+), 153 deletions(-)
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Okay, after some more testing, I'd like to remove the !OF for next iteration.
The reason is that I have a usecase where I have a single kernel image with
devictree support (ie CONFIG_OF=y), but with support for both devicetree and
legacy platforms. In this case, a platform such as lubbock can boot :
- with devicetree
- with legacy arch/arm/mach-pxa/lubbock.c
In this kernel, the !OF Kconfig prevents the legacy version from working, as
pxa2xx-cpufreq is descarded even if it is needed in the legacy version.
Therefore, I'd like to respin without this !OF.