Re: [PATCHv7 2/8] printk: rename nmi.c and exported api

From: Steven Rostedt
Date: Wed Feb 01 2017 - 10:51:06 EST


On Wed, 1 Feb 2017 10:48:05 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Tue, 27 Dec 2016 23:16:05 +0900
> Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> wrote:
>
> > A preparation patch for printk_safe work. No functional change.
> > - rename nmi.c to print_safe.c
> > - add `printk_safe' prefix to some (which used both by printk-safe
> > and printk-nmi) of the exported functions.
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
>
> Looks good.
>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
>

I take that back. This isn't the patch I reviewed :-p (I'm not sure I
totally agree with the entire change, but I'm not going to argue it
either).

I was reviewing patch 3, but needed to apply this patch to look at all
the changes of patch 3, but I did the reply here, where it was meant
for patch 3.

-- Steve