Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata
From: Heiko Stuebner
Date: Fri Feb 16 2018 - 02:04:33 EST
Am Mittwoch, 14. Februar 2018, 21:08:59 CET schrieb Jernej Skrabec:
> dw_hdmi shouldn't set drvdata since some drivers might need to store
> it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi
> instead to store it in drvdata. This way drivers are responsible to
> store and pass structure when needed.
>
> Idea was taken from the following commit:
> 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata")
>
> Cc: p.zabel@xxxxxxxxxxxxxx
> Cc: narmstrong@xxxxxxxxxxxx
> Cc: Laurent.pinchart@xxxxxxxxxxxxxxxx
> Cc: hjc@xxxxxxxxxxxxxx
> Cc: heiko@xxxxxxxxx
> Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>
For the Rockchip-part
Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>
Acked-by: Heiko Stuebner <heiko@xxxxxxxxx>