Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata

From: Philipp Zabel
Date: Mon Feb 19 2018 - 08:50:00 EST


On Wed, 2018-02-14 at 21:08 +0100, Jernej Skrabec wrote:
> dw_hdmi shouldn't set drvdata since some drivers might need to store
> it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi
> instead to store it in drvdata. This way drivers are responsible to
> store and pass structure when needed.
>
> Idea was taken from the following commit:
> 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata")
>
> Cc: p.zabel@xxxxxxxxxxxxxx
> Cc: narmstrong@xxxxxxxxxxxx
> Cc: Laurent.pinchart@xxxxxxxxxxxxxxxx
> Cc: hjc@xxxxxxxxxxxxxx
> Cc: heiko@xxxxxxxxx
> Acked-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>

For i.MX:
Tested-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
Acked-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

regards
Philipp