Re: [PATCH] PM / wakeirq: Add wakeup name to dedicated wake irqs

[Rafael J. Wysocki]

On Wed, Feb 14, 2018 at 12:23 PM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Feb 9, 2018 at 6:14 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>> This makes it easy to grep :wakeup /proc/interrupts.
>
> I used to have another patch (not published) to provide this
> information via /sys/kernel/irq.
>
> OK, here we are:
>
>
>> +       namelen = strlen(dev_name(dev)) + strlen(postfix) + 1;
>> +       wirq->name = kzalloc(namelen, GFP_KERNEL);
>
> kasprintf()

It's a bit hard to comment patches sent as attachments, but I'll try anyway. :-)

IMO it is somewhat excessive to put the entire sprintf() under a raw
spinlock and it's not even necessary.

The value can change any time after you've dropped the lock and in
particular before the function returns, so why bother with locking?
desc will not go away from under you at that point anyway.