Re: [PATCH v3 5/7] watchdog: mtk: allow setting timeout in devicetree

[Guenter Roeck]

On 02/18/2018 04:08 PM, Rob Herring wrote:
> On Sun, Feb 11, 2018 at 09:08:45PM +0100, Marcus Folkesson wrote:
> > watchdog_init_timeout() will allways pick timeout_param since it
> > defaults to a valid timeout.
> >
> > By following best practice described in
> > Documentation/watchdog/watchdog-kernel-api.txt, it also
> > let us to set timout-sec property in devicetree.
>
> Same problems in this one.

Same answer. In the existing driver;

        mtk_wdt->wdt_dev.timeout = WDT_MAX_TIMEOUT;

Guenter

> > Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx>
> > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/watchdog/mtk-wdt.txt | 4 ++++
> >   drivers/watchdog/mtk_wdt.c                             | 2 +-
> >   2 files changed, 5 insertions(+), 1 deletion(-)