Re: [PATCH] xfs: Remove noinline from #define STATIC

From: Eric Sandeen
Date: Mon Nov 12 2018 - 15:12:12 EST


On 11/10/18 7:21 PM, Joe Perches wrote:
> Reduce total object size quite a bit (~32KB) and presumably
> improve performance at the same time.
>
> Total object size old vs new (x86-64 defconfig with xfs)
>
> text data bss dec hex filename
> - 959351 165573 632 1125556 112cb4 (TOTALS) (old)
> + 924683 165669 632 1090984 10a5a8 (TOTALS) (new)

And what does it do to maximum stack excursions?

-Eric

> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> fs/xfs/xfs_linux.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_linux.h b/fs/xfs/xfs_linux.h
> index edbd5a210df2..f33c8b626bca 100644
> --- a/fs/xfs/xfs_linux.h
> +++ b/fs/xfs/xfs_linux.h
> @@ -242,7 +242,7 @@ static inline uint64_t howmany_64(uint64_t x, uint32_t y)
> #endif /* XFS_WARN */
> #endif /* DEBUG */
>
> -#define STATIC static noinline
> +#define STATIC static
>
> #ifdef CONFIG_XFS_RT
>
>