Re: [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller.

[Peter Chen]

On Tue, Dec 11, 2018 at 6:19 PM Roger Quadros <rogerq@xxxxxx> wrote:
>
> Pawel,
>
> On 10/12/18 14:39, Pawel Laszczak wrote:
> > This patch aim at documenting USB related dt-bindings for the
> > Cadence USBSS-DRD controller.
> >
> > Signed-off-by: Pawel Laszczak <pawell@xxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/usb/cdns3-usb.txt     | 31 +++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> > new file mode 100644
> > index 000000000000..ae4a255f0b10
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> > @@ -0,0 +1,31 @@
> > +Binding for the Cadence USBSS-DRD controller
> > +
> > +Required properties:
> > +  - reg: Physical base address and size of the controller's register areas.
> > +      Controller has 3 different regions:
> > +      region 1 - HOST registers area
> > +      region 2 - DEVICE registers area
> > +      region 3 - OTG/DRD registers area
> > +  - compatible: Should contain: "cdns,usb3"
> > +  - interrupts: Interrupt specifier. Refer to interrupt bindings.
> > +             Driver supports only single interrupt line.
> > +                This single interrupt is shared between Device,
> > +             host and OTG/DRD part of driver.
> > +
> > +Optional propertiesi:
>
> s/propertiesi/properties
>
> > + - maximum-speed : valid arguments are "super-speed", "high-speed" and
> > +                   "full-speed"; refer to usb/generic.txt
> > + - dr_mode: Should be one of "host", "peripheral" or "otg".
> > + - phys: reference to the USB PHY
> > + - phy-names: name of the USB PHY, should be "cdns3,usbphy"
> > +
> > +
> > +Example:
> > +     usb@f3000000 {
> > +             compatible = "cdns,usb3";
> > +             interrupts = <USB_IRQ  7 IRQ_TYPE_LEVEL_HIGH>;
> > +             reg = <0xf3000000 0x10000       //memory area for HOST registers
> > +                     0xf3010000 0x10000      //memory area for DEVICE registers
> > +                     0xf3020000 0x10000>;    //memory area for OTG/DRD registers
>
> Use "/* <comment> */" instead.
>
> > +     };
> > +
> >

When running git am to apply patch, it has below warning, please fix them.

Applying: dt-bindings: add binding for USBSS-DRD controller.
.git/rebase-apply/patch:42: new blank line at EOF.
+
warning: 1 line adds whitespace errors.