Re: [PATCH net-next] ethtool: Remove unnecessary null check in ethtool_rx_flow_rule_create

From: David Miller
Date: Sat Feb 09 2019 - 02:05:42 EST


From: Nathan Chancellor <natechancellor@xxxxxxxxx>
Date: Thu, 7 Feb 2019 21:46:53 -0700

> net/core/ethtool.c:3023:19: warning: address of array
> 'ext_m_spec->h_dest' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> if (ext_m_spec->h_dest) {
> ~~ ~~~~~~~~~~~~^~~~~~
>
> h_dest is an array, it can't be null so remove this check.
>
> Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator")
> Link: https://github.com/ClangBuiltLinux/linux/issues/353
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

Applied.