Re: Oops in rpc_clnt_debugfs_register() from debugfs change

From: David Howells
Date: Tue Feb 12 2019 - 09:57:41 EST


Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> - if (!xprt->debugfs) {
> + if (IS_ERR_OR_NULL(xprt->debugfs)) {

That works, though I don't much like the idea of there being an error there.

Looking in rpc_xprt_debugfs_register() there are two now-dodgy looking checks
on the result of debugfs calls.

David