Re: [PATCH] x86/boot: clean up headers
From: Stephen Rothwell
Date: Fri Mar 01 2019 - 21:28:15 EST
Hi Nick,
On Fri, 1 Mar 2019 16:07:14 -0800 Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote:
>
> It turns out that arch/x86/boot/string.c doesn't actually need
> linux/kernel.h, simply linux/limits.h and linux/compiler.h. Include them,
> and sort the headers alphabetically.
One small nit: please do not do the sort in the same commit as the bug
fix. It just complicates the review and has (a remote) possibility of
adding a new problem. (Not a big issue here, but in general cleanups
and bug fixes should be separate.)
--
Cheers,
Stephen Rothwell
Attachment:
pgp54tf6hBWND.pgp
Description: OpenPGP digital signature