Re: [PATCH] x86/boot: clean up headers

[Stephen Rothwell]

Hi Nick,

On Sat, 2 Mar 2019 13:27:50 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> On Fri,  1 Mar 2019 16:07:14 -0800 Nick Desaulniers <ndesaulniers@xxxxxxxxxx> wrote:
> >
> > It turns out that arch/x86/boot/string.c doesn't actually need
> > linux/kernel.h, simply linux/limits.h and linux/compiler.h. Include them,
> > and sort the headers alphabetically.  
> 
> One small nit: please do not do the sort in the same commit as the bug
> fix.  It just complicates the review and has (a remote) possibility of
> adding a new problem.  (Not a big issue here, but in general cleanups
> and bug fixes should be separate.)

Also it is *very* common for headers to be included in the order:
linux/ asm/ and then local.

-- 
Cheers,
Stephen Rothwell

Attachment: pgp2of5UrW_ck.pgp
Description: OpenPGP digital signature