Re: [PATCH] vfs: Move kernel_read_file() to fs/read_write.c

From: Mimi Zohar
Date: Mon Mar 04 2019 - 11:49:38 EST

On Mon, 2019-03-04 at 16:22 +0000, David Howells wrote:
> Mimi Zohar <zohar@xxxxxxxxxxxxx> wrote:
> > > Move kernel_read_file() to fs/read_write.c and out of fs/exec.c as it's not
> > > actually used by anything in the execve subsystem.
> >
> > All files being opened by the kernel should be calling one of these
> > helper routines. ÂHas that changed?
> prepare_binprm() uses kernel_read() and has done since at least 2014. The
> binfmt drivers also use kernel_read().
> Since kernel_read_file() is used by a bunch of things that aren't exec, even
> if we switch exec to it, it should probably still go in fs/read_write.c since
> it seems generic.

Oh, commit bdd1d2d3d251 ("fs: fix kernel_read prototype") moved
kernel_read() to fs/read_write.c without moving the helpers.
ÂDefinitely makes sense to move the helpers. ÂPlease include a
reference to the commit in this patch.Â

Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>