RE: [PATCH 4/4] scsi: ufs: hisi: fix ufs_hba_variant_ops passing
From: Avri Altman
Date: Wed Mar 06 2019 - 06:43:30 EST
>
> Without CONFIG_OF, the of_match_node() helper does not evaluate
> its argument, and the compiler warns about the unused variable:
>
> drivers/scsi/ufs/ufs-hisi.c: In function 'ufs_hisi_probe':
> drivers/scsi/ufs/ufs-hisi.c:673:17: error: unused variable 'dev' [-
> Werror=unused-variable]
>
> Rework this code to pass the data directly, and while we're
> at it, correctly handle the const pointers.
>
> Fixes: 653fcb07d95e ("scsi: ufs: Add HI3670 SoC UFS driver support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Reviewed-by: Avri Altman <avri.altman@xxxxxxx>
Arnd, Thank you for your comments.
Regards,
Avri