Re: [PATCH v1] lib/test_printf: Switch to bitmap_zalloc()

From: Andy Shevchenko
Date: Thu Mar 07 2019 - 09:12:38 EST


+Cc: Petr

On Mon, Mar 04, 2019 at 12:00:09PM +0200, Andy Shevchenko wrote:
> Switch to bitmap_zalloc() to show clearly what we are allocating.
> Besides that it returns pointer of bitmap type instead of opaque void *.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> lib/test_printf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/test_printf.c b/lib/test_printf.c
> index 659b6cc0d483..e8206d8d2d08 100644
> --- a/lib/test_printf.c
> +++ b/lib/test_printf.c
> @@ -481,14 +481,14 @@ static void __init
> large_bitmap(void)
> {
> const int nbits = 1 << 16;
> - unsigned long *bits = kcalloc(BITS_TO_LONGS(nbits), sizeof(long), GFP_KERNEL);
> + unsigned long *bits = bitmap_zalloc(nbits, GFP_KERNEL);
> if (!bits)
> return;
>
> bitmap_set(bits, 1, 20);
> bitmap_set(bits, 60000, 15);
> test("1-20,60000-60014", "%*pbl", nbits, bits);
> - kfree(bits);
> + bitmap_free(bits);
> }
>
> static void __init
> --
> 2.20.1
>

--
With Best Regards,
Andy Shevchenko