RE: [PATCH V7 1/3] watchdog: imx_sc: Add i.MX system controller watchdog support

[Anson Huang]

Best Regards!
Anson Huang

> -----Original Message-----
> From: Aisheng Dong
> Sent: 2019年3月7日 22:00
> To: Anson Huang <anson.huang@xxxxxxx>; catalin.marinas@xxxxxxx;
> will.deacon@xxxxxxx; shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; wim@xxxxxxxxxxxxxxxxxx;
> linux@xxxxxxxxxxxx; Andy Gross <andy.gross@xxxxxxxxxx>; heiko@xxxxxxxxx;
> horms+renesas@xxxxxxxxxxxx; arnd@xxxxxxxx;
> maxime.ripard@xxxxxxxxxxx; jagan@xxxxxxxxxxxxxxxxxxxx;
> bjorn.andersson@xxxxxxxxxx; enric.balletbo@xxxxxxxxxxxxx;
> marc.w.gonzalez@xxxxxxx; olof@xxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> watchdog@xxxxxxxxxxxxxxx
> Cc: dl-linux-imx <linux-imx@xxxxxxx>
> Subject: RE: [PATCH V7 1/3] watchdog: imx_sc: Add i.MX system controller
> watchdog support
> 
> [...]
> 
> > > As I replied in another mail, it actually does not depend on SCU.
> > > Let's wait for Rob's comment on whether we could move watchdog Out
> > > of SCU node.
> >
> > Per previous discussion, the dependency here is to prevent enabling
> > this module for platform without IMX SCU, although it does NOT use SCU
> > IPC call, but the SMC call trap into ARM-Trusted-Firmware will
> > eventually call SCU API, so it still depends on IMX SCU hardware, I am
> > NOT very sure if it is correct to remove it here.
> >
> 
> Then it's ATF depends on SCU, not this virtual watchdog based on ARM SIP,
> right?

But we don't have ATF driver in Linux kernel..., I am confused, anyway, if Guenter
agrees, I can remove this dependency here.

Anson.

> 
> Regards
> Dong Aisheng
> 
> > >
> > > > +	depends on HAVE_ARM_SMCCC
> > > > +	select WATCHDOG_CORE
> > > > +	help
> > > > +	  This is the driver for the system controller watchdog
> > > > +	  on the NXP i.MX SoCs with system controller inside.
> > > > +	  If you have one of these processors and wish to have
> > > > +	  watchdog support enabled, say Y, otherwise say N.
> > > > +