Re: [PATCH v1 6/6] virtio-balloon: Add support for aerating memory via hinting
From: Michael S. Tsirkin
Date: Tue Jul 16 2019 - 12:13:13 EST
On Tue, Jul 16, 2019 at 03:01:52PM +0000, Wang, Wei W wrote:
> On Tuesday, July 16, 2019 10:41 PM, Hansen, Dave wrote:
> > Where is the page allocator integration? The set you linked to has 5 patches,
> > but only 4 were merged. This one is missing:
> >
> > https://lore.kernel.org/patchwork/patch/961038/
>
> For some reason, we used the regular page allocation to get pages
> from the free list at that stage.
This is what Linus suggested, that is why:
https://lkml.org/lkml/2018/6/27/461
and
https://lkml.org/lkml/2018/7/11/795
See also
https://lkml.org/lkml/2018/7/10/1157
for some failed attempts to upstream mm core changes
related to this.
> This part could be improved by Alex
> or Nitesh's approach.
>
> The page address transmission from the balloon driver to the host
> device could reuse what's upstreamed there. I think you could add a
> new VIRTIO_BALLOON_CMD_xx for your usages.
>
> Best,
> Wei