Re: [PATCH -next] iwlwifi: dbg: work around clang bug by marking debug strings static

From: Nick Desaulniers
Date: Tue Jul 16 2019 - 17:18:48 EST


On Tue, Jul 16, 2019 at 2:15 PM Luca Coelho <luca@xxxxxxxxx> wrote:
>
> On Tue, 2019-07-16 at 10:28 -0700, Nick Desaulniers wrote:
> > On Thu, Jul 11, 2019 at 7:15 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > Better still would be to use the format string directly
> > > in both locations instead of trying to deduplicate it
> > > via storing it into a separate pointer.
> > >
> > > Let the compiler/linker consolidate the format.
> > > It's smaller object code, allows format/argument verification,
> > > and is simpler for humans to understand.
> >
> > Whichever Kalle prefers, I just want my CI green again.
>
> We already changed this in a later internal patch, which will reach the
> mainline (-next) soon. So let's skip this for now.

Ok, but this has now regressed into mainline and is blocking Linaro's
ToolChain Working Group's CI, so if you could send a bugfix ASAP we'd
appreciate it.
--
Thanks,
~Nick Desaulniers