Re: [patch v2] crypto: ccp - Fix SEV_VERSION_GREATER_OR_EQUAL

From: Herbert Xu
Date: Thu Jul 18 2019 - 01:42:03 EST


On Fri, Jul 12, 2019 at 01:41:58PM -0700, David Rientjes wrote:
> SEV_VERSION_GREATER_OR_EQUAL() will fail if upgrading from 2.2 to 3.1, for
> example, because the minor version is not equal to or greater than the
> major.
>
> Fix this and move to a static inline function for appropriate type
> checking.
>
> Fixes: edd303ff0e9e ("crypto: ccp - Add DOWNLOAD_FIRMWARE SEV command")
> Reported-by: Cfir Cohen <cfir@xxxxxxxxxx>
> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
> ---
> v2: no need to check api_major >= maj after checking api_major > maj
> per Thomas
>
> drivers/crypto/ccp/psp-dev.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt