Re: [PATCH v2 04/22] x86/kvm: Don't call kvm_spurious_fault() from .fixup

From: Paolo Bonzini
Date: Thu Jul 18 2019 - 09:18:56 EST


On 18/07/19 15:16, Sean Christopherson wrote:
>> Acked-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>>
>> This has a side effect of adding a jump in a generally hot path, but
>> let's hope that the speculation gods for once help us.
> Any reason not to take the same approach as vmx_vmenter() and ud2 directly
> from fixup? I've never found kvm_spurious_fault() to be all that helpful,
> IMO it's a win win. :-)

Honestly I've never seen a backtrace from here but I would rather not
regret this when a customer encounters it...

Paolo