Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal

[Nadav Amit]

> On Jul 18, 2019, at 5:26 AM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
> 
> On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote:
>> Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces)
>> 
>> A #GP is reported in the guest when requesting balloon inflation via
>> virtio-balloon. The reason is that the virtio-balloon driver has
>> removed the page from its internal page list (via balloon_page_pop),
>> but balloon_page_enqueue_one also calls "list_del"  to do the removal.
>> This is necessary when it's used from balloon_page_enqueue_list, but
>> not from balloon_page_enqueue_one.
>> 
>> So remove the list_del balloon_page_enqueue_one, and update some
>> comments as a reminder.
>> 
>> Signed-off-by: Wei Wang <wei.w.wang@xxxxxxxxx>
> 
> 
> ok I posted v3 with typo fixes. 1/2 is this patch with comment changes. Pls take a look.

Thanks (Wei, Michael) for taking care of it. Please cc me on future
iterations of the patch.

Acked-by: Nadav Amit <namit@xxxxxxxxxx>