Re: linux-next: Tree for Jul 18 (header build error)

From: Stephen Rothwell
Date: Thu Jul 18 2019 - 20:06:02 EST


Hi all,

On Thu, 18 Jul 2019 10:00:22 -0700 Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> on x86_64, when CONFIG_BLOCK is not set:
>
> CC include/linux/iomap.h.s
> In file included from <command-line>:0:0:
> ./../include/linux/iomap.h: In function âiomap_sectorâ:
> ./../include/linux/iomap.h:76:48: error: âSECTOR_SHIFTâ undeclared (first use in this function); did you mean âSECTIONS_SHIFTâ?
> return (iomap->addr + pos - iomap->offset) >> SECTOR_SHIFT;
> ^~~~~~~~~~~~

include/linux/iomap.h should only be used when CONFIG_BLOCK is set (if
you follow the Kconfig trail). So maybe this header should only be
compile tested if CONFIG_BLOCK is set.

--
Cheers,
Stephen Rothwell

Attachment: pgpLfmBrYy8nX.pgp
Description: OpenPGP digital signature