Re: [PATCH] [v2] blkdev: always export SECTOR_SHIFT

[Masahiro Yamada]

Hi Arnd,

On Fri, Jul 19, 2019 at 8:32 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> When CONFIG_BLOCK is disabled, SECTOR_SHIFT is unknown, and this leads
> to a failure in the testing infrastructure added from commit c93a0368aaa2
> ("kbuild: do not create wrappers for header-test-y"):

I think this should be

commit 43c78d88036e ("kbuild: compile-test kernel headers to ensure
they are self-contained")

Thanks.


>
> In file included from <built-in>:3:
> include/linux/iomap.h:76:48: error: use of undeclared identifier 'SECTOR_SHIFT'
>         return (iomap->addr + pos - iomap->offset) >> SECTOR_SHIFT;
>
> If we want to keep build testing all headers, the macro needs to
> either be defined, or not used. Move it out of the #ifdef
> section to ensure it is visible.
>
> Fixes: db074436f421 ("iomap: move the direct IO code into a separate file")
> Link: https://lore.kernel.org/lkml/20190718125509.775525-1-arnd@xxxxxxxx/T/
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> The discussion about the build testing is still going on, but I promised
> to send this version anyway for reference. I see no other header-test
> failures in randconfig builds with this patch.
> ---



-- 
Best Regards
Masahiro Yamada