Re: [PATCH v9 2/8] sched/core: Streamlining calls to task_rq_unlock()

[Juri Lelli]

On 22/07/19 10:21, Dietmar Eggemann wrote:
> On 7/19/19 3:59 PM, Juri Lelli wrote:
> > From: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> 
> [...]
> 
> > @@ -4269,8 +4269,8 @@ static int __sched_setscheduler(struct task_struct *p,
> >  			 */
> >  			if (!cpumask_subset(span, &p->cpus_allowed) ||
> 
> This doesn't apply cleanly on v5.3-rc1 anymore due to commit
> 3bd3706251ee ("sched/core: Provide a pointer to the valid CPU mask").
> 
> >  			    rq->rd->dl_bw.bw == 0) {
> > -				task_rq_unlock(rq, p, &rf);
> > -				return -EPERM;
> > +				retval = -EPERM;
> > +				goto unlock;
> >  			}
> >  		}
> >  #endif

Thanks for reporting. The set is based on cgroup/for-next (as of last
week), though. I can of course rebase on tip/sched/core or mainline if
needed.

Best,

Juri