Re: [PATCH v9 4/8] sched/deadline: Fix bandwidth accounting at all levels after offline migration

From: Dietmar Eggemann
Date: Mon Jul 22 2019 - 07:07:39 EST


On 7/19/19 3:59 PM, Juri Lelli wrote:

[...]

> @@ -557,6 +558,38 @@ static struct rq *dl_task_offline_migration(struct rq *rq, struct task_struct *p
> double_lock_balance(rq, later_rq);
> }
>
> + if (p->dl.dl_non_contending || p->dl.dl_throttled) {
> + /*
> + * Inactive timer is armed (or callback is running, but
> + * waiting for us to release rq locks). In any case, when it
> + * will file (or continue), it will see running_bw of this

s/file/fire ?

> + * task migrated to later_rq (and correctly handle it).

Is this because of dl_task_timer()->enqueue_task_dl()->task_contending()
setting dl_se->dl_non_contending = 0 ?

[...]