Re: [PATCH] tracing: kmem: convert call_site addresses to user friendly symbols

From: Steven Rostedt
Date: Mon Jul 22 2019 - 09:43:51 EST



Looking at the kbuild report...

On Fri, 19 Jul 2019 22:22:40 -0400
"George G. Davis" <george_davis@xxxxxxxxxx> wrote:

> diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h
> index eb57e3037deb..ae18e61fa1c0 100644
> --- a/include/trace/events/kmem.h
> +++ b/include/trace/events/kmem.h
> @@ -35,7 +35,7 @@ DECLARE_EVENT_CLASS(kmem_alloc,
> __entry->gfp_flags = gfp_flags;
> ),
>
> - TP_printk("call_site=%lx ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s",
> + TP_printk("call_site=%pS ptr=%p bytes_req=%zu bytes_alloc=%zu gfp_flags=%s",

Note, %lx expects an unsigned long, %pS expects a pointer.

> __entry->call_site,

You need to change the above to: (void *)__entry->call_site,

-- Steve

> __entry->ptr,
> __entry->bytes_req,