Re: [RFC 3/7] x86/percpu: Use C for percpu accesses when possible

[Nadav Amit]

> On Jul 22, 2019, at 1:52 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> 
> On Thu, Jul 18, 2019 at 10:41:06AM -0700, Nadav Amit wrote:
> 
>> diff --git a/arch/x86/include/asm/preempt.h b/arch/x86/include/asm/preempt.h
>> index 99a7fa9ab0a3..60f97b288004 100644
>> --- a/arch/x86/include/asm/preempt.h
>> +++ b/arch/x86/include/asm/preempt.h
>> @@ -91,7 +91,8 @@ static __always_inline void __preempt_count_sub(int val)
>>  */
>> static __always_inline bool __preempt_count_dec_and_test(void)
>> {
>> -	return GEN_UNARY_RMWcc("decl", __preempt_count, e, __percpu_arg([var]));
>> +	return GEN_UNARY_RMWcc("decl", __my_cpu_var(__preempt_count), e,
>> +			       __percpu_arg([var]));
>> }
> 
> Should this be in the previous patch?

Yes, it should.