Re: [PATCH v2 3/3] HID: core: only warn once of oversize hid report

From: Joshua Clayton
Date: Mon Jul 22 2019 - 17:43:24 EST


On Mon, Jul 22, 2019 at 3:30 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Mon, 2019-07-22 at 15:26 -0600, stillcompiling@xxxxxxxxx wrote:
> > From: Joshua Clayton <stillcompiling@xxxxxxxxx>
>
> Thanks Joshua
>
> > On HP spectre x360 convertible the message:
> > hid-sensor-hub 001F:8087:0AC2.0002: hid_field_extract() called with n (192) > 32! (kworker/1:2)
> > is continually printed many times per second, crowding out all else
> > Protect dmesg by printing the warning only one time.
> []
> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> []
> > @@ -1311,8 +1311,8 @@ u32 hid_field_extract(const struct hid_device *hid, u8 *report,
> > unsigned offset, unsigned n)
> > {
> > if (n > 32) {
> > - hid_warn(hid, "hid_field_extract() called with n (%d) > 32! (%s)\n",
> > - n, current->comm);
> > + hid_warn_once(hid, "%s() called with n (%d) > 32! (%s)\n",
> > + __func__ ,n , current->comm);
>
> All the other bits are fine, but this line is oddly written
> with unusual spacing around 'n'.
>
> Normally it'd be something like:
>
> hid_warn_once(hid, "%s: called with n (%d) > 32! (%s)\n",
> __func__, n, current->comm);
Gah!
Not only that but I missed a semicolon in patch 1. Will fix, (compile)
and send v3 pdq.
Sorry about the extra noise.
>
>