Re: [PATCH v3 23/26] memstick: use PCI_STD_NUM_BARS

From: Ulf Hansson
Date: Fri Sep 20 2019 - 03:43:01 EST


On Mon, 16 Sep 2019 at 22:47, Denis Efremov <efremov@xxxxxxxxx> wrote:
>
> Use define PCI_STD_NUM_BARS instead of PCI_ROM_RESOURCE for the number of
> PCI BARs.
>
> Cc: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> Cc: Alex Dubov <oakad@xxxxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>

Assuming this depends on other changes in the series? Thus this is
probably for PCI maintainers to pick up?

Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

Kind regards
Uffe

> ---
> drivers/memstick/host/jmb38x_ms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
> index 32747425297d..fd281c1d39b1 100644
> --- a/drivers/memstick/host/jmb38x_ms.c
> +++ b/drivers/memstick/host/jmb38x_ms.c
> @@ -848,7 +848,7 @@ static int jmb38x_ms_count_slots(struct pci_dev *pdev)
> {
> int cnt, rc = 0;
>
> - for (cnt = 0; cnt < PCI_ROM_RESOURCE; ++cnt) {
> + for (cnt = 0; cnt < PCI_STD_NUM_BARS; ++cnt) {
> if (!(IORESOURCE_MEM & pci_resource_flags(pdev, cnt)))
> break;
>
> --
> 2.21.0
>