Re: [PATCH 3.16 000/132] 3.16.74-rc1 review

From: Miguel Ojeda
Date: Sun Sep 22 2019 - 15:26:41 EST


On Sun, Sep 22, 2019 at 9:04 PM Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
>
> It looks like this is triggered by you switching arm builds from gcc 8
> to 9, rather than by any code change.
>
> Does it actually make sense to try to support building Linux 3.16 with
> gcc 9? If so, I suppose I'll need to add:
>
> commit edc966de8725f9186cc9358214da89d335f0e0bd
> Author: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
> Date: Fri Aug 2 12:37:56 2019 +0200
>
> Backport minimal compiler_attributes.h to support GCC 9
>
> commit a6e60d84989fa0e91db7f236eda40453b0e44afa
> Author: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
> Date: Sat Jan 19 20:59:34 2019 +0100
>
> include/linux/module.h: copy __init/__exit attrs to init/cleanup_module

Yeah, those should fix it.

Cheers,
Miguel