Re: [PATCH v6 09/10] power: supply: Support ROHM bd99954 charger

[andriy.shevchenko@xxxxxxxxxxxxxxx]

On Wed, Mar 25, 2020 at 03:20:33PM +0200, andriy.shevchenko@xxxxxxxxxxxxxxx wrote:
> On Wed, Mar 25, 2020 at 01:00:21PM +0000, Vaittinen, Matti wrote:

> But why?
> 
> You really uglify the code with ifdeffery, make a dependency to OF (yes, you
> will have to have of.h include) only because of that silly
> macro and save 64 bytes of memory footprint.

And on top of that for !OF configuration you prevent your driver to be usable.
(Consider PRP0001 ACPI case, for example)

-- 
With Best Regards,
Andy Shevchenko